read role every refresh

handlers/login.go

@@ -49,34 +49,21 @@ func (aH *AccessHandler) Login(c *gin.Context) {
 		aH.logger.Error("Login", "user empty")
 		c.JSON(http.StatusBadRequest, models.NewJsonMessageResponse("user empty"))
 		return
-	} else if !user.ExpirationIsValid() {
-		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", user.Name))
-		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+user.Name+" is expired"))
-		return
 	}
 
 	// Fetch user record from DB
-	var dbRecord []models.User
+	dbUser, hasError := aH.getUserFromDB(c, user.Name)
-	err := aH.dbHandler.GetByKey(&dbRecord, "user_name", user.Name, false)
+	if hasError {
-	if err != nil {
-		aH.logger.Error("Login", err)
-		c.JSON(http.StatusBadRequest, models.NewJsonErrorResponse(err))
-		return
-	}
-
-	if len(dbRecord) > 1 {
-		aH.logger.Error("Login", "more than one record found")
-		c.JSON(http.StatusInternalServerError, models.NewJsonMessageResponse("internal error"))
 		return
 	}
 
 	// Check password
-	if !utils.CheckPassword(user.Password, dbRecord[0].Password) {
+	if !utils.CheckPassword(user.Password, dbUser.Password) {
 		aH.logger.Error("Login", "invalid password")
 		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("invalid credentials"))
 		return
 	}
-	user = dbRecord[0]
+	user = dbUser
 
 	// -----------------------------
 	// 🔑 TOKEN CREATION
@@ -93,7 +80,6 @@ func (aH *AccessHandler) Login(c *gin.Context) {
 		"role":     user.Role,
 		"type":     "access",
 		"exp":      accessTokenExp.Unix(),
-		"userExpiration": user.Expiration,
 	})
 
 	// Create refresh token
@@ -103,7 +89,6 @@ func (aH *AccessHandler) Login(c *gin.Context) {
 		"role":     user.Role,
 		"type":     "refresh",
 		"exp":      refreshTokenExp.Unix(),
-		"userExpiration": user.GetExpiration(),
 	})
 
 	// Sign tokens
@@ -179,11 +164,9 @@ func (aH *AccessHandler) Refresh(c *gin.Context) {
 
 	username := claims["username"].(string)
 	id := int(claims["id"].(float64))
-	role := claims["role"].(string)
 
-	if !expirationDateValid(claims["userExpiration"].(string)) {
+	user, hasError := aH.getUserFromDB(c, username)
-		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", username))
+	if hasError {
-		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+username+" is expired"))
 		return
 	}
 
@@ -193,7 +176,7 @@ func (aH *AccessHandler) Refresh(c *gin.Context) {
 	newAccess := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
 		"id":       id,
 		"username": username,
-		"role":     role,
+		"role":     user.Role,
 		"exp":      accessExp.Unix(),
 	})
 	accessString, _ := newAccess.SignedString(ACCESS_SECRET)
@@ -253,15 +236,33 @@ func (aH *AccessHandler) Logout(c *gin.Context) {
 	c.JSON(http.StatusOK, gin.H{"message": "logged out"})
 }
 
-func expirationDateValid(expiration string) bool {
+func (aH *AccessHandler) getUserFromDB(c *gin.Context, userName string) (user models.User, hasError bool) {
-	if expiration == "" {
+	hasError = true
-		return true // No expiration = always valid
+	// Fetch user record from DB
-	}
+	var dbRecord []models.User
-
+	err := aH.dbHandler.GetByKey(&dbRecord, "user_name", userName, false)
-	t, err := time.Parse(time.RFC3339, expiration)
 	if err != nil {
-		return false // Invalid date format
+		aH.logger.Error("Login", err)
+		c.JSON(http.StatusBadRequest, models.NewJsonErrorResponse(err))
+		return
 	}
 
-	return time.Now().Before(t)
+	if len(dbRecord) == 0 {
+		aH.logger.Error("Login", "no user "+userName+" found")
+		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("invalid credentials"))
+		return
+	}
+
+	if len(dbRecord) > 1 {
+		aH.logger.Error("Login", "more than one record found")
+		c.JSON(http.StatusInternalServerError, models.NewJsonMessageResponse("internal error"))
+		return
+	}
+
+	if !dbRecord[0].ExpirationIsValid() {
+		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", userName))
+		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+userName+" is expired"))
+		return
+	}
+	return dbRecord[0], false
 }

models/user.go

@@ -1,6 +1,8 @@
 package models
 
-import "time"
+import (
+	"time"
+)
 
 type User struct {
 	Id         uint     `gorm:"primaryKey" json:"id"`
@@ -8,7 +10,7 @@ type User struct {
 	Email      string   `gorm:"column:email" json:"email"`
 	Role       string   `gorm:"column:role" json:"role,omitempty"`
 	Password   string   `gorm:"column:password" json:"password"`
-	Expiration *time.Time `gorm:"column:expiration" json:"expiration,omitempty"`
+	Expiration string   `gorm:"column:expiration" json:"expiration,omitempty"`
 	Settings   Settings `gorm:"type:json" json:"settings"`
 }
 
@@ -17,15 +19,10 @@ func (u *User) IsValid() bool {
 }
 
 func (u *User) ExpirationIsValid() bool {
-	if u.Expiration == nil {
+	if u.Expiration == "" || u.Expiration == "never" {
 		return true
 	}
-	return time.Now().Before(*u.Expiration)
+	loc := time.Now().Location()
-}
+	parsedTime, _ := time.ParseInLocation("2006-01-02 15:04:05", u.Expiration, loc)
-
+	return parsedTime.After(time.Now())
-func (u *User) GetExpiration() string {
-	if u.Expiration == nil {
-		return ""
-	}
-	return u.Expiration.Format(time.RFC3339)
 }