replace static secrets with enviroment variables

accessHandler.go

@@ -1,10 +1,15 @@
 package AccessHandler
 
 import (
+	"os"
+
 	"gitea.tecamino.com/paadi/access-handler/handlers"
 	"gitea.tecamino.com/paadi/tecamino-logger/logging"
 )
 
 func NewAccessHandler(path string, logger *logging.Logger) (aH *handlers.AccessHandler, err error) {
+	logger.Debug("NewAccessHandler", "get enviroment variables")
+	handlers.ACCESS_SECRET = []byte(os.Getenv("ACCESS_SECRET"))
+	handlers.REFRESH_SECRET = []byte(os.Getenv("REFRESH_SECRET"))
 	return handlers.NewAccessHandler(path, logger)
 }

db_test.go

@@ -16,6 +16,10 @@ import (
 )
 
 func TestDatabase(t *testing.T) {
+	// set enviroment variables
+	os.Setenv("ACCESS_SECRET", "12345678910111213141516171819202")
+	os.Setenv("REFRESH_SECRET", "9998979695949392919089888786858")
+
 	dbName := "user.db"
 	if _, err := os.Stat(dbName); err == nil {
 		t.Log("remove user.db to start test with empty database")
@@ -154,6 +158,9 @@ func TestDatabase(t *testing.T) {
 }
 
 func TestLoginAndAuthorization(t *testing.T) {
+	os.Setenv("ACCESS_SECRET", "12345678910111213141516171819202")
+	os.Setenv("REFRESH_SECRET", "9998979695949392919089888786858")
+
 	gin.SetMode(gin.TestMode)
 
 	// Setup your AccessHandler and router

handlers/login.go

@@ -16,9 +16,9 @@ import (
 // 🔐 AUTHENTICATION CONSTANTS
 // -----------------------------
 
-// JWT secrets (replace "*" with strong random values in production!)
+// JWT secrets
-var ACCESS_SECRET = []byte("ShFRprALcXjlosJ2hFCnGYGG3Ce2uRx6")
+var ACCESS_SECRET []byte
-var REFRESH_SECRET = []byte("pQIjuX6g6Tzf0FEfdScxttT3hlL9NFaa")
+var REFRESH_SECRET []byte
 
 // DOMAIN defines where cookies are valid. Change this in production.
 var DOMAIN = "localhost"
@@ -49,34 +49,21 @@ func (aH *AccessHandler) Login(c *gin.Context) {
 		aH.logger.Error("Login", "user empty")
 		c.JSON(http.StatusBadRequest, models.NewJsonMessageResponse("user empty"))
 		return
-	} else if !user.ExpirationIsValid() {
-		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", user.Name))
-		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+user.Name+" is expired"))
-		return
 	}
 
 	// Fetch user record from DB
-	var dbRecord []models.User
+	dbUser, hasError := aH.getUserFromDB(c, user.Name)
-	err := aH.dbHandler.GetByKey(&dbRecord, "user_name", user.Name, false)
+	if hasError {
-	if err != nil {
-		aH.logger.Error("Login", err)
-		c.JSON(http.StatusBadRequest, models.NewJsonErrorResponse(err))
-		return
-	}
-
-	if len(dbRecord) > 1 {
-		aH.logger.Error("Login", "more than one record found")
-		c.JSON(http.StatusInternalServerError, models.NewJsonMessageResponse("internal error"))
 		return
 	}
 
 	// Check password
-	if !utils.CheckPassword(user.Password, dbRecord[0].Password) {
+	if !utils.CheckPassword(user.Password, dbUser.Password) {
 		aH.logger.Error("Login", "invalid password")
 		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("invalid credentials"))
 		return
 	}
-	user = dbRecord[0]
+	user = dbUser
 
 	// -----------------------------
 	// 🔑 TOKEN CREATION
@@ -88,22 +75,20 @@ func (aH *AccessHandler) Login(c *gin.Context) {
 
 	// Create access token
 	accessToken := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
-		"id":             user.Id,
+		"id":       user.Id,
-		"username":       user.Name,
+		"username": user.Name,
-		"role":           user.Role,
+		"role":     user.Role,
-		"type":           "access",
+		"type":     "access",
-		"exp":            accessTokenExp.Unix(),
+		"exp":      accessTokenExp.Unix(),
-		"userExpiration": user.Expiration,
 	})
 
 	// Create refresh token
 	refreshToken := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
-		"id":             user.Id,
+		"id":       user.Id,
-		"username":       user.Name,
+		"username": user.Name,
-		"role":           user.Role,
+		"role":     user.Role,
-		"type":           "refresh",
+		"type":     "refresh",
-		"exp":            refreshTokenExp.Unix(),
+		"exp":      refreshTokenExp.Unix(),
-		"userExpiration": user.GetExpiration(),
 	})
 
 	// Sign tokens
@@ -179,11 +164,9 @@ func (aH *AccessHandler) Refresh(c *gin.Context) {
 
 	username := claims["username"].(string)
 	id := int(claims["id"].(float64))
-	role := claims["role"].(string)
 
-	if !expirationDateValid(claims["userExpiration"].(string)) {
+	user, hasError := aH.getUserFromDB(c, username)
-		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", username))
+	if hasError {
-		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+username+" is expired"))
 		return
 	}
 
@@ -193,7 +176,7 @@ func (aH *AccessHandler) Refresh(c *gin.Context) {
 	newAccess := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
 		"id":       id,
 		"username": username,
-		"role":     role,
+		"role":     user.Role,
 		"exp":      accessExp.Unix(),
 	})
 	accessString, _ := newAccess.SignedString(ACCESS_SECRET)
@@ -253,15 +236,33 @@ func (aH *AccessHandler) Logout(c *gin.Context) {
 	c.JSON(http.StatusOK, gin.H{"message": "logged out"})
 }
 
-func expirationDateValid(expiration string) bool {
+func (aH *AccessHandler) getUserFromDB(c *gin.Context, userName string) (user models.User, hasError bool) {
-	if expiration == "" {
+	hasError = true
-		return true // No expiration = always valid
+	// Fetch user record from DB
-	}
+	var dbRecord []models.User
-
+	err := aH.dbHandler.GetByKey(&dbRecord, "user_name", userName, false)
-	t, err := time.Parse(time.RFC3339, expiration)
 	if err != nil {
-		return false // Invalid date format
+		aH.logger.Error("Login", err)
+		c.JSON(http.StatusBadRequest, models.NewJsonErrorResponse(err))
+		return
 	}
 
-	return time.Now().Before(t)
+	if len(dbRecord) == 0 {
+		aH.logger.Error("Login", "no user "+userName+" found")
+		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("invalid credentials"))
+		return
+	}
+
+	if len(dbRecord) > 1 {
+		aH.logger.Error("Login", "more than one record found")
+		c.JSON(http.StatusInternalServerError, models.NewJsonMessageResponse("internal error"))
+		return
+	}
+
+	if !dbRecord[0].ExpirationIsValid() {
+		aH.logger.Error("Login", fmt.Sprintf("user %s is expired", userName))
+		c.JSON(http.StatusUnauthorized, models.NewJsonMessageResponse("user "+userName+" is expired"))
+		return
+	}
+	return dbRecord[0], false
 }

models/permission.go

@@ -12,7 +12,7 @@ func (r *Permissions) DefaultPermissions() {
 	*r = append(*r,
 		Permission{Name: "settings", Permission: 7},
 		Permission{Name: "userSettings", Permission: 7},
-		Permission{Name: "members", Permission: 7},
+		Permission{Name: "members", Permission: 15},
 		Permission{Name: "events", Permission: 7},
 		Permission{Name: "responsible", Permission: 7},
 	)

models/settings.go

@@ -12,6 +12,7 @@ type Settings struct {
 	SecondaryColor     string `json:"secondaryColor,omitempty"`
 	SecondaryColorText string `json:"secondaryColorText,omitempty"`
 	Icon               string `json:"icon,omitempty"`
+	AppName            string `json:"appName,omitempty"`
 	DatabaseName       string `json:"databaseName,omitempty"`
 	DatabaseToken      string `json:"databaseToken,omitempty"`
 }

models/user.go

@@ -1,15 +1,17 @@
 package models
 
-import "time"
+import (
+	"time"
+)
 
 type User struct {
-	Id         uint       `gorm:"primaryKey" json:"id"`
+	Id         uint     `gorm:"primaryKey" json:"id"`
-	Name       string     `gorm:"column:user_name" json:"user"`
+	Name       string   `gorm:"column:user_name" json:"user"`
-	Email      string     `gorm:"column:email" json:"email"`
+	Email      string   `gorm:"column:email" json:"email"`
-	Role       string     `gorm:"column:role" json:"role,omitempty"`
+	Role       string   `gorm:"column:role" json:"role,omitempty"`
-	Password   string     `gorm:"column:password" json:"password"`
+	Password   string   `gorm:"column:password" json:"password"`
-	Expiration *time.Time `gorm:"column:expiration" json:"expiration,omitempty"`
+	Expiration string   `gorm:"column:expiration" json:"expiration,omitempty"`
-	Settings   Settings   `gorm:"type:json" json:"settings"`
+	Settings   Settings `gorm:"type:json" json:"settings"`
 }
 
 func (u *User) IsValid() bool {
@@ -17,15 +19,10 @@ func (u *User) IsValid() bool {
 }
 
 func (u *User) ExpirationIsValid() bool {
-	if u.Expiration == nil {
+	if u.Expiration == "" || u.Expiration == "never" {
 		return true
 	}
-	return time.Now().Before(*u.Expiration)
+	loc := time.Now().Location()
-}
+	parsedTime, _ := time.ParseInLocation("2006-01-02 15:04:05", u.Expiration, loc)
-
+	return parsedTime.After(time.Now())
-func (u *User) GetExpiration() string {
-	if u.Expiration == nil {
-		return ""
-	}
-	return u.Expiration.Format(time.RFC3339)
 }