fix delete and existing for more than one id

This commit is contained in:
Adrian Zürcher
2025-10-29 21:38:17 +01:00
parent e65fb8fdf5
commit d2a4a3d548

View File

@@ -234,17 +234,24 @@ func (dH *DBHandler) UpdateValuesByKey(model any, key string, value any) error {
// //
// Returns: // Returns:
// - error: Any deletion error. // - error: Any deletion error.
func (dH *DBHandler) DeleteById(model any, id ...uint) error { func (dH *DBHandler) DeleteById(model any, ids ...uint) error {
if id[0] == 0 { if len(ids) == 0 {
return fmt.Errorf("no IDs provided")
}
if ids[0] == 0 {
dH.logger.Debug("deleteById", "delete all") dH.logger.Debug("deleteById", "delete all")
return dH.db.Where("1 = 1").Delete(model).Error return dH.db.Where("1 = 1").Delete(model).Error
} }
dH.logger.Debug("deleteById", "delete ids"+fmt.Sprint(id)) dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids))
if err := dH.Exists(model, "id", id, false); err != nil {
return err // Always use Model() to avoid GORMs “limit 1” safeguard
if err := dH.db.Model(model).Where("id IN ?", ids).Delete(nil).Error; err != nil {
return fmt.Errorf("delete failed: %w", err)
} }
return dH.db.Delete(model, id).Error
return nil
} }
// deleteByKey // deleteByKey
@@ -294,20 +301,34 @@ func (dH *DBHandler) DeleteByKey(model any, key string, value any, LikeSearch bo
// //
// Returns: // Returns:
// - error: “no record found” or DB error. // - error: “no record found” or DB error.
func (dH *DBHandler) Exists(model any, key string, value any, LikeSearch bool) (err error) { func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) (err error) {
if LikeSearch { var query string
value = strings.ReplaceAll(fmt.Sprint(value), "*", "%")
key = key + " LIKE ?" switch v := value.(type) {
case []string, []int, []uint, []int64, []uint64, []float64:
// Handle slice case — use IN clause
query = fmt.Sprintf("%s IN ?", key)
case string:
if likeSearch {
v = strings.ReplaceAll(v, "*", "%")
query = fmt.Sprintf("%s LIKE ?", key)
value = v
} else { } else {
key = key + " = ?" query = fmt.Sprintf("%s = ?", key)
}
default:
// Handle any other single value (numbers, bools, etc.)
query = fmt.Sprintf("%s = ?", key)
} }
dH.logger.Debug("exists", "check if exists key "+key+" value "+fmt.Sprint(value)) dH.logger.Debug("exists", "check if exists key "+query+" value "+fmt.Sprint(value))
err = dH.db.Where(key, value).First(model).Error
err = dH.db.Where(query, value).First(model).Error
if errors.Is(err, gorm.ErrRecordNotFound) { if errors.Is(err, gorm.ErrRecordNotFound) {
return fmt.Errorf("no record found for %s %v", key[:len(key)-1], value) return fmt.Errorf("no record found for %s %v", key, value)
} else if err != nil { } else if err != nil {
return fmt.Errorf("query failed: %w", err) return fmt.Errorf("query failed: %w", err)
} }
return
return nil
} }