3 Commits

Author SHA1 Message Date
Adrian Zürcher
14cb20f306 fix existing function add reflect, slow but safe 2025-11-07 08:01:50 +01:00
Adrian Zürcher
2b18549f02 fix exist function for array of values and error handling delete 2025-10-29 22:14:07 +01:00
Adrian Zürcher
d2a4a3d548 fix delete and existing for more than one id 2025-10-29 21:38:17 +01:00

View File

@@ -234,17 +234,27 @@ func (dH *DBHandler) UpdateValuesByKey(model any, key string, value any) error {
// //
// Returns: // Returns:
// - error: Any deletion error. // - error: Any deletion error.
func (dH *DBHandler) DeleteById(model any, id ...uint) error { func (dH *DBHandler) DeleteById(model any, ids ...uint) error {
if id[0] == 0 { if len(ids) == 0 {
return fmt.Errorf("no IDs provided")
}
if ids[0] == 0 {
dH.logger.Debug("deleteById", "delete all") dH.logger.Debug("deleteById", "delete all")
return dH.db.Where("1 = 1").Delete(model).Error return dH.db.Where("1 = 1").Delete(model).Error
} }
dH.logger.Debug("deleteById", "delete ids"+fmt.Sprint(id)) dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids))
if err := dH.Exists(model, "id", id, false); err != nil { if !dH.Exists(model, "id", ids, false) {
return err return errors.New("no matching id(s) found")
} }
return dH.db.Delete(model, id).Error
// Always use Model() to avoid GORMs “limit 1” safeguard
if err := dH.db.Model(model).Where("id IN ?", ids).Delete(nil).Error; err != nil {
return fmt.Errorf("delete failed: %w", err)
}
return err
} }
// deleteByKey // deleteByKey
@@ -275,39 +285,45 @@ func (dH *DBHandler) DeleteByKey(model any, key string, value any, LikeSearch bo
return dH.db.Where(key+" = ?", value).Delete(model).Error return dH.db.Where(key+" = ?", value).Delete(model).Error
} }
// exists func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) (found bool) {
// var query string
// Description: var args any
//
// Checks whether a record exists matching the specified key/value filter. // Detect LIKE and IN behavior
// val := reflect.ValueOf(value)
// Behavior: isSlice := val.Kind() == reflect.Slice
// - Performs a `First` query on the database.
// - If `LikeSearch` is true, performs a LIKE query. switch {
// - Returns an error if the record does not exist or query fails. case isSlice:
// if val.Len() == 0 {
// Parameters: dH.logger.Error("Exists", fmt.Sprintf("empty slice for %s", key))
// - model: Model struct type to search. return false
// - key: Column name to filter by. }
// - value: Value to match. query = fmt.Sprintf("%s IN ?", key)
// - LikeSearch: Whether to use wildcard search. args = value
//
// Returns: case likeSearch:
// - error: “no record found” or DB error. str := strings.ReplaceAll(fmt.Sprint(value), "*", "%")
func (dH *DBHandler) Exists(model any, key string, value any, LikeSearch bool) (err error) { query = fmt.Sprintf("%s LIKE ?", key)
if LikeSearch { args = str
value = strings.ReplaceAll(fmt.Sprint(value), "*", "%")
key = key + " LIKE ?" default:
} else { query = fmt.Sprintf("%s = ?", key)
key = key + " = ?" args = value
} }
dH.logger.Debug("exists", "check if exists key "+key+" value "+fmt.Sprint(value)) dH.logger.Debug("exists", "checking existence for key "+query+" value "+fmt.Sprint(args))
err = dH.db.Where(key, value).First(model).Error
if errors.Is(err, gorm.ErrRecordNotFound) { t := reflect.TypeOf(model)
return fmt.Errorf("no record found for %s %v", key[:len(key)-1], value) if t.Kind() == reflect.Ptr {
} else if err != nil { t = t.Elem()
return fmt.Errorf("query failed: %w", err)
} }
return
tx := dH.db.Where(query, args).Find(model)
if tx.Error != nil {
dH.logger.Error("Exists", fmt.Sprintf("query failed: %w", tx.Error))
return false
}
return tx.RowsAffected > 0
} }