1 Commits

Author SHA1 Message Date
Adrian Zürcher
2b18549f02 fix exist function for array of values and error handling delete 2025-10-29 22:14:07 +01:00

View File

@@ -245,13 +245,14 @@ func (dH *DBHandler) DeleteById(model any, ids ...uint) error {
} }
dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids)) dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids))
err := dH.Exists(model, "id", ids, false)
// Always use Model() to avoid GORMs “limit 1” safeguard // Always use Model() to avoid GORMs “limit 1” safeguard
if err := dH.db.Model(model).Where("id IN ?", ids).Delete(nil).Error; err != nil { if err := dH.db.Model(model).Where("id IN ?", ids).Delete(nil).Error; err != nil {
return fmt.Errorf("delete failed: %w", err) return fmt.Errorf("delete failed: %w", err)
} }
return nil return err
} }
// deleteByKey // deleteByKey
@@ -301,33 +302,42 @@ func (dH *DBHandler) DeleteByKey(model any, key string, value any, LikeSearch bo
// //
// Returns: // Returns:
// - error: “no record found” or DB error. // - error: “no record found” or DB error.
func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) (err error) { func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) error {
var query string var query string
var args any
switch v := value.(type) { // Detect LIKE and IN behavior
case []string, []int, []uint, []int64, []uint64, []float64: val := reflect.ValueOf(value)
// Handle slice case — use IN clause isSlice := val.Kind() == reflect.Slice
query = fmt.Sprintf("%s IN ?", key)
case string: switch {
if likeSearch { case isSlice:
v = strings.ReplaceAll(v, "*", "%") if val.Len() == 0 {
query = fmt.Sprintf("%s LIKE ?", key) return fmt.Errorf("empty slice for %s", key)
value = v
} else {
query = fmt.Sprintf("%s = ?", key)
} }
query = fmt.Sprintf("%s IN ?", key)
args = value
case likeSearch:
str := strings.ReplaceAll(fmt.Sprint(value), "*", "%")
query = fmt.Sprintf("%s LIKE ?", key)
args = str
default: default:
// Handle any other single value (numbers, bools, etc.)
query = fmt.Sprintf("%s = ?", key) query = fmt.Sprintf("%s = ?", key)
args = value
} }
dH.logger.Debug("exists", "check if exists key "+query+" value "+fmt.Sprint(value)) dH.logger.Debug("exists", "checking existence for key "+query+" value "+fmt.Sprint(args))
err = dH.db.Where(query, value).First(model).Error var count int64
if errors.Is(err, gorm.ErrRecordNotFound) { tx := dH.db.Model(model).Where(query, args).Count(&count)
if tx.Error != nil {
return fmt.Errorf("query failed: %w", tx.Error)
}
if count == 0 {
return fmt.Errorf("no record found for %s %v", key, value) return fmt.Errorf("no record found for %s %v", key, value)
} else if err != nil {
return fmt.Errorf("query failed: %w", err)
} }
return nil return nil