4 Commits

Author SHA1 Message Date
Adrian Zürcher
98094abf3e fix delete function 2025-11-07 08:17:48 +01:00
Adrian Zürcher
97a3ebf3a0 remove refelect 2025-11-07 08:04:01 +01:00
Adrian Zürcher
f59d3e9b1b fix existing function add reflect, slow but safe 2025-11-07 08:02:19 +01:00
Adrian Zürcher
14cb20f306 fix existing function add reflect, slow but safe 2025-11-07 08:01:50 +01:00

View File

@@ -218,41 +218,23 @@ func (dH *DBHandler) UpdateValuesByKey(model any, key string, value any) error {
return dH.db.Model(lookUpModel).Updates(model).Error return dH.db.Model(lookUpModel).Updates(model).Error
} }
// deleteById
//
// Description:
//
// Deletes records by their ID(s).
//
// Behavior:
// - If the first ID == 0, all records in the table are deleted.
// - Otherwise, deletes the provided IDs.
//
// Parameters:
// - model: Model struct type representing the table.
// - id: Variadic list of IDs to delete.
//
// Returns:
// - error: Any deletion error.
func (dH *DBHandler) DeleteById(model any, ids ...uint) error { func (dH *DBHandler) DeleteById(model any, ids ...uint) error {
if len(ids) == 0 { if len(ids) == 0 {
return fmt.Errorf("no IDs provided") return fmt.Errorf("no IDs provided")
} }
if ids[0] == 0 { if len(ids) == 1 && ids[0] == 0 {
dH.logger.Debug("deleteById", "delete all") dH.logger.Debug("deleteById", "delete ALL records!")
return dH.db.Where("1 = 1").Delete(model).Error return dH.db.Session(&gorm.Session{AllowGlobalUpdate: true}).
Delete(model).Error
} }
dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids)) dH.logger.Debug("deleteById", "delete ids "+fmt.Sprint(ids))
err := dH.Exists(model, "id", ids, false)
// Always use Model() to avoid GORMs “limit 1” safeguard if err := dH.db.Delete(model, ids).Error; err != nil {
if err := dH.db.Model(model).Where("id IN ?", ids).Delete(nil).Error; err != nil {
return fmt.Errorf("delete failed: %w", err) return fmt.Errorf("delete failed: %w", err)
} }
return nil
return err
} }
// deleteByKey // deleteByKey
@@ -283,26 +265,7 @@ func (dH *DBHandler) DeleteByKey(model any, key string, value any, LikeSearch bo
return dH.db.Where(key+" = ?", value).Delete(model).Error return dH.db.Where(key+" = ?", value).Delete(model).Error
} }
// exists func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) (found bool) {
//
// Description:
//
// Checks whether a record exists matching the specified key/value filter.
//
// Behavior:
// - Performs a `First` query on the database.
// - If `LikeSearch` is true, performs a LIKE query.
// - Returns an error if the record does not exist or query fails.
//
// Parameters:
// - model: Model struct type to search.
// - key: Column name to filter by.
// - value: Value to match.
// - LikeSearch: Whether to use wildcard search.
//
// Returns:
// - error: “no record found” or DB error.
func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) error {
var query string var query string
var args any var args any
@@ -313,7 +276,8 @@ func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) e
switch { switch {
case isSlice: case isSlice:
if val.Len() == 0 { if val.Len() == 0 {
return fmt.Errorf("empty slice for %s", key) dH.logger.Error("Exists", fmt.Sprintf("empty slice for %s", key))
return false
} }
query = fmt.Sprintf("%s IN ?", key) query = fmt.Sprintf("%s IN ?", key)
args = value args = value
@@ -330,15 +294,11 @@ func (dH *DBHandler) Exists(model any, key string, value any, likeSearch bool) e
dH.logger.Debug("exists", "checking existence for key "+query+" value "+fmt.Sprint(args)) dH.logger.Debug("exists", "checking existence for key "+query+" value "+fmt.Sprint(args))
var count int64 tx := dH.db.Where(query, args).Find(model)
tx := dH.db.Model(model).Where(query, args).Count(&count)
if tx.Error != nil { if tx.Error != nil {
return fmt.Errorf("query failed: %w", tx.Error) dH.logger.Error("Exists", fmt.Sprintf("query failed: %v", tx.Error))
return false
} }
return tx.RowsAffected > 0
if count == 0 {
return fmt.Errorf("no record found for %s %v", key, value)
}
return nil
} }