change chrome path priority close #1

converter/converter.go

@@ -2,41 +2,35 @@ package converter
 
 import (
 	"context"
+	"errors"
+	"fmt"
 	"os"
 	"path/filepath"
 	"runtime"
+	"strings"
 	"time"
 
+	"gitea.tecamino.com/paadi/html2pdf/models"
 	"github.com/chromedp/cdproto/page"
 	"github.com/chromedp/chromedp"
 )
 
+// html to pdf converter structure for
 type Converter struct {
 	chromePath string
+	ctx        context.Context
+	cancel     context.CancelFunc
 }
 
-func NewConverter(chromePath string) *Converter {
-	return &Converter{chromePath: chromePath}
-}
-
-func (c *Converter) Convert(imputFile, outputFile string) error {
-
-	chromePath := c.getChromePath()
-	htmlURL := "file://"
-
-	switch runtime.GOOS {
-	case "windows":
-		htmlURL += "/"
-	}
-
-	// Convert to absolute path
-	absPath, err := filepath.Abs(imputFile)
+// NewConverter starts a new converter instance with a chrome headless shell executable
+func NewConverter(chromePath string) (*Converter, error) {
+	var err error
+	c := &Converter{chromePath: chromePath}
+	chromePath, err = c.getChromePath()
 	if err != nil {
-		return err
+		return nil, err
 	}
 
-	htmlURL += filepath.ToSlash(absPath)
-
 	opts := append(chromedp.DefaultExecAllocatorOptions[:],
 		chromedp.ExecPath(chromePath),
 		chromedp.NoSandbox,
@@ -44,17 +38,43 @@ func (c *Converter) Convert(imputFile, outputFile string) error {
 		chromedp.DisableGPU,
 	)
 
-	allocCtx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
-	defer cancel()
-	ctx, cancel := chromedp.NewContext(allocCtx)
-	defer cancel()
+	var allocCtx context.Context
+	allocCtx, c.cancel = chromedp.NewExecAllocator(context.Background(), opts...)
+	c.ctx, c.cancel = chromedp.NewContext(allocCtx)
+	return c, nil
+}
 
-	ctx, cancel = context.WithTimeout(ctx, 60*time.Second)
-	defer cancel()
+// Convert converts all given input files
+func (c *Converter) Convert(files ...models.File) error {
+	for _, f := range files {
+		if f.Input == "" || filepath.Ext(f.Input) != ".html" {
+			return fmt.Errorf("no .html input file path provided: %s", f.Input)
+		} else if f.Output == "" || filepath.Ext(f.Output) != ".pdf" {
+			return fmt.Errorf("no .pdf output file path provided: %s", f.Output)
+		}
 
-	var pdf []byte
-	err = chromedp.Run(ctx,
-		chromedp.Navigate(htmlURL),
+		var htmlURL strings.Builder
+		htmlURL.WriteString("file://")
+
+		switch runtime.GOOS {
+		case "windows":
+			htmlURL.WriteString("/")
+		}
+
+		// Convert to absolute path
+		absPath, err := filepath.Abs(f.Input)
+		if err != nil {
+			return err
+		}
+
+		htmlURL.WriteString(filepath.ToSlash(absPath))
+
+		c.ctx, c.cancel = context.WithTimeout(c.ctx, 60*time.Second)
+		defer c.cancel()
+
+		var pdfData []byte
+		err = chromedp.Run(c.ctx,
+			chromedp.Navigate(htmlURL.String()),
 			chromedp.WaitReady("body", chromedp.ByQuery),
 			chromedp.ActionFunc(func(ctx context.Context) error {
 				buf, _, err := page.PrintToPDF().
@@ -65,7 +85,7 @@ func (c *Converter) Convert(imputFile, outputFile string) error {
 				if err != nil {
 					return err
 				}
-			pdf = buf
+				pdfData = buf
 				return nil
 			}),
 		)
@@ -74,17 +94,30 @@ func (c *Converter) Convert(imputFile, outputFile string) error {
 		}
 
 		// Save PDF to file
-	if err := os.WriteFile(outputFile, pdf, 0644); err != nil {
+		if err := os.WriteFile(f.Output, pdfData, 0644); err != nil {
 			return err
 		}
+	}
 	return nil
 }
 
 // getChromePath checks for system Chrome, else falls back to bundled headless shell
-func (c *Converter) getChromePath() string {
+func (c *Converter) getChromePath() (string, error) {
+
+	chromeExec := "chrome-headless-shell"
+	if runtime.GOOS == "windows" {
+		chromeExec += ".exe"
+	}
+
+	path := filepath.Join(c.chromePath, chromeExec)
+	if _, err := os.Stat(path); err == nil {
+		return path, nil
+	}
+
 	// Candidate paths for system Chrome
 	candidates := []string{}
 
+	// Fallback:
 	switch runtime.GOOS {
 	case "windows":
 		candidates = []string{
@@ -108,14 +141,9 @@ func (c *Converter) getChromePath() string {
 	// Check system paths first
 	for _, path := range candidates {
 		if _, err := os.Stat(path); err == nil {
-			return path
+			return path, nil
 		}
 	}
 
-	// Fallback: use bundled headless shell
-	chromeExec := "chrome-headless-shell"
-	if runtime.GOOS == "windows" {
-		chromeExec += ".exe"
-	}
-	return filepath.Join(c.chromePath, chromeExec)
+	return "", errors.New("chrome path not found")
 }

html2pdf.go

@@ -1,8 +1,24 @@
 package html2pdf
 
-import "gitea.tecamino.com/paadi/html2pdf/converter"
+import (
+	"gitea.tecamino.com/paadi/html2pdf/converter"
+	"gitea.tecamino.com/paadi/html2pdf/models"
+)
 
+// Convert converts one .html file to .pdf
 func Convert(chromePath, inputFile, outputFile string) error {
-	c := converter.NewConverter(chromePath)
-	return c.Convert(inputFile, outputFile)
+	input := models.File{
+		Input:  inputFile,
+		Output: outputFile,
+	}
+	c, err := converter.NewConverter(chromePath)
+	if err != nil {
+		return err
+	}
+	return c.Convert(input)
+}
+
+// NewConverterInstance start new chrome headless shell instance
+func NewConverterInstance(chromePath string) (*converter.Converter, error) {
+	return converter.NewConverter(chromePath)
 }

html2pdf_test.go

@@ -1,12 +1,53 @@
 package html2pdf
 
-import "testing"
+import (
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"gitea.tecamino.com/paadi/html2pdf/converter"
+	"gitea.tecamino.com/paadi/html2pdf/models"
+)
 
 func TestConvert(t *testing.T) {
-	t.Log("start test")
+	t.Log("start test convert one file")
 
 	err := Convert("./assets", "dst/test.html", "out.pdf")
 	if err != nil {
 		t.Fatal(err)
 	}
 }
+
+func TestConvertFiles(t *testing.T) {
+	t.Log("start test convert files")
+
+	rootPath := "dst"
+	files, err := os.ReadDir(rootPath)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	var input []models.File
+	for _, f := range files {
+		ext := filepath.Ext(f.Name())
+		if ext != ".html" {
+			continue
+		}
+
+		input = append(input, models.File{
+			Input:  filepath.Join(rootPath, f.Name()),
+			Output: strings.Replace(f.Name(), ext, ".pdf", 1),
+		})
+	}
+
+	c, err := converter.NewConverter("./assets")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if err := c.Convert(input...); err != nil {
+		t.Fatal(err)
+	}
+	t.Log("test successfull")
+}

models/file.go

@@ -0,0 +1,9 @@
+package models
+
+type Files []File
+
+// input model for converter
+type File struct {
+	Input  string
+	Output string
+}