fix hid terminal on windows

converter/converter.go

@@ -8,7 +8,6 @@ import (
 	"path/filepath"
 	"runtime"
 	"strings"
-	"syscall"
 	"time"
 
 	"gitea.tecamino.com/paadi/html2pdf/models"
@@ -28,10 +27,6 @@ type Converter struct {
 func NewConverter(chromePath string) (*Converter, error) {
 	var err error
 
-	if runtime.GOOS == "windows" {
-		hideConsole()
-	}
-
 	c := &Converter{chromePath: chromePath}
 	chromePath, err = c.getChromePath()
 	if err != nil {
@@ -45,6 +40,8 @@ func NewConverter(chromePath string) (*Converter, error) {
 		chromedp.DisableGPU,
 	)
 
+	opts = append(opts, platformOptions())
+
 	var allocCtx context.Context
 	allocCtx, c.cancel = chromedp.NewExecAllocator(context.Background(), opts...)
 	c.ctx, c.cancel = chromedp.NewContext(allocCtx)
@@ -85,7 +82,6 @@ func (c *Converter) Convert(files ...models.File) error {
 		htmlURL.WriteString(filepath.ToSlash(absPath))
 
 		c.ctx, c.cancel = context.WithTimeout(c.ctx, 60*time.Second)
-		defer c.cancel()
 
 		var pdfData []byte
 		err = chromedp.Run(c.ctx,
@@ -104,15 +100,19 @@ func (c *Converter) Convert(files ...models.File) error {
 				return nil
 			}),
 		)
+
 		if err != nil {
+			c.cancel()
 			return err
 		}
 
 		// Save PDF to file
 		if err := os.WriteFile(f.Output, pdfData, 0644); err != nil {
+			c.cancel()
 			return err
 		}
 	}
+	c.cancel()
 	return nil
 }
 
@@ -162,19 +162,3 @@ func (c *Converter) getChromePath() (string, error) {
 
 	return "", errors.New("chrome path not found")
 }
-
-var (
-	kernel32         = syscall.NewLazyDLL("kernel32.dll")
-	user32           = syscall.NewLazyDLL("user32.dll")
-	getConsoleWindow = kernel32.NewProc("GetConsoleWindow")
-	showWindow       = user32.NewProc("ShowWindow")
-)
-
-const SW_HIDE = 0
-
-func hideConsole() {
-	hwnd, _, _ := getConsoleWindow.Call()
-	if hwnd != 0 {
-		showWindow.Call(hwnd, SW_HIDE)
-	}
-}

converter/hideOthers.go

@@ -0,0 +1,10 @@
+//go:build !windows
+
+package converter
+
+import "github.com/chromedp/chromedp"
+
+func platformOptions() chromedp.ExecAllocatorOption {
+	// Returns a no-op option for Mac/Linux
+	return chromedp.NoSandbox
+}

converter/hideWindows.go

@@ -0,0 +1,20 @@
+//go:build windows
+
+package converter
+
+import (
+	"os/exec"
+	"syscall"
+
+	"github.com/chromedp/chromedp"
+)
+
+func platformOptions() chromedp.ExecAllocatorOption {
+	return chromedp.ModifyCmdFunc(func(cmd *exec.Cmd) {
+		if cmd.SysProcAttr == nil {
+			cmd.SysProcAttr = &syscall.SysProcAttr{}
+		}
+		cmd.SysProcAttr.HideWindow = true
+		cmd.SysProcAttr.CreationFlags = 0x08000000 // CREATE_NO_WINDOW
+	})
+}

html2pdf_test.go

@@ -42,7 +42,7 @@ func TestConvertFiles(t *testing.T) {
 		})
 	}
 
-	c, err := converter.NewConverter("./assets")
+	c, err := converter.NewConverter("assets/chrome-headless-shell/win64")
 	if err != nil {
 		t.Fatal(err)
 	}