fix hid terminal on windows

converter/converter.go

@@ -20,11 +20,13 @@ type Converter struct {
 	chromePath string
 	ctx        context.Context
 	cancel     context.CancelFunc
+	progress   func(progress int)
 }
 
 // NewConverter starts a new converter instance with a chrome headless shell executable
 func NewConverter(chromePath string) (*Converter, error) {
 	var err error
+
 	c := &Converter{chromePath: chromePath}
 	chromePath, err = c.getChromePath()
 	if err != nil {
@@ -38,15 +40,25 @@ func NewConverter(chromePath string) (*Converter, error) {
 		chromedp.DisableGPU,
 	)
 
+	opts = append(opts, platformOptions())
+
 	var allocCtx context.Context
 	allocCtx, c.cancel = chromedp.NewExecAllocator(context.Background(), opts...)
 	c.ctx, c.cancel = chromedp.NewContext(allocCtx)
 	return c, nil
 }
 
+func (c *Converter) SetProgressCallback(cb func(progress int)) {
+	c.progress = cb
+}
+
 // Convert converts all given input files
 func (c *Converter) Convert(files ...models.File) error {
-	for _, f := range files {
+	for i, f := range files {
+		if c.progress != nil {
+			c.progress(i + 1)
+		}
+
 		if f.Input == "" || filepath.Ext(f.Input) != ".html" {
 			return fmt.Errorf("no .html input file path provided: %s", f.Input)
 		} else if f.Output == "" || filepath.Ext(f.Output) != ".pdf" {
@@ -70,7 +82,6 @@ func (c *Converter) Convert(files ...models.File) error {
 		htmlURL.WriteString(filepath.ToSlash(absPath))
 
 		c.ctx, c.cancel = context.WithTimeout(c.ctx, 60*time.Second)
-		defer c.cancel()
 
 		var pdfData []byte
 		err = chromedp.Run(c.ctx,
@@ -89,15 +100,19 @@ func (c *Converter) Convert(files ...models.File) error {
 				return nil
 			}),
 		)
+
 		if err != nil {
+			c.cancel()
 			return err
 		}
 
 		// Save PDF to file
 		if err := os.WriteFile(f.Output, pdfData, 0644); err != nil {
+			c.cancel()
 			return err
 		}
 	}
+	c.cancel()
 	return nil
 }
 

converter/hideOthers.go

@@ -0,0 +1,10 @@
+//go:build !windows
+
+package converter
+
+import "github.com/chromedp/chromedp"
+
+func platformOptions() chromedp.ExecAllocatorOption {
+	// Returns a no-op option for Mac/Linux
+	return chromedp.NoSandbox
+}

converter/hideWindows.go

@@ -0,0 +1,20 @@
+//go:build windows
+
+package converter
+
+import (
+	"os/exec"
+	"syscall"
+
+	"github.com/chromedp/chromedp"
+)
+
+func platformOptions() chromedp.ExecAllocatorOption {
+	return chromedp.ModifyCmdFunc(func(cmd *exec.Cmd) {
+		if cmd.SysProcAttr == nil {
+			cmd.SysProcAttr = &syscall.SysProcAttr{}
+		}
+		cmd.SysProcAttr.HideWindow = true
+		cmd.SysProcAttr.CreationFlags = 0x08000000 // CREATE_NO_WINDOW
+	})
+}

html2pdf_test.go

@@ -1,6 +1,7 @@
 package html2pdf
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -41,11 +42,15 @@ func TestConvertFiles(t *testing.T) {
 		})
 	}
 
-	c, err := converter.NewConverter("./assets")
+	c, err := converter.NewConverter("assets/chrome-headless-shell/win64")
 	if err != nil {
 		t.Fatal(err)
 	}
 
+	c.SetProgressCallback(func(progress int) {
+		fmt.Println(progress)
+	})
+
 	if err := c.Convert(input...); err != nil {
 		t.Fatal(err)
 	}