fix compile error for other os than windows

converter/converter.go

@@ -20,11 +20,17 @@ type Converter struct {
 	chromePath string
 	ctx        context.Context
 	cancel     context.CancelFunc
+	progress   func(progress int)
 }
 
 // NewConverter starts a new converter instance with a chrome headless shell executable
 func NewConverter(chromePath string) (*Converter, error) {
 	var err error
+
+	if runtime.GOOS == "windows" {
+		hideConsole()
+	}
+
 	c := &Converter{chromePath: chromePath}
 	chromePath, err = c.getChromePath()
 	if err != nil {
@@ -44,9 +50,17 @@ func NewConverter(chromePath string) (*Converter, error) {
 	return c, nil
 }
 
+func (c *Converter) SetProgressCallback(cb func(progress int)) {
+	c.progress = cb
+}
+
 // Convert converts all given input files
 func (c *Converter) Convert(files ...models.File) error {
-	for _, f := range files {
+	for i, f := range files {
+		if c.progress != nil {
+			c.progress(i + 1)
+		}
+
 		if f.Input == "" || filepath.Ext(f.Input) != ".html" {
 			return fmt.Errorf("no .html input file path provided: %s", f.Input)
 		} else if f.Output == "" || filepath.Ext(f.Output) != ".pdf" {
@@ -70,7 +84,6 @@ func (c *Converter) Convert(files ...models.File) error {
 		htmlURL.WriteString(filepath.ToSlash(absPath))
 
 		c.ctx, c.cancel = context.WithTimeout(c.ctx, 60*time.Second)
-		defer c.cancel()
 
 		var pdfData []byte
 		err = chromedp.Run(c.ctx,
@@ -89,15 +102,19 @@ func (c *Converter) Convert(files ...models.File) error {
 				return nil
 			}),
 		)
+
 		if err != nil {
+			c.cancel()
 			return err
 		}
 
 		// Save PDF to file
 		if err := os.WriteFile(f.Output, pdfData, 0644); err != nil {
+			c.cancel()
 			return err
 		}
 	}
+	c.cancel()
 	return nil
 }
 

converter/hideOthers.go

@@ -0,0 +1,9 @@
+//go:build !windows
+
+package converter
+
+// hideConsole does nothing on non-Windows systems
+func hideConsole() {
+	// macOS and Linux don't have the same "console window" concept
+	// that needs manual hiding at runtime like Windows.
+}

converter/hideWindows.go

@@ -0,0 +1,23 @@
+//go:build windows
+
+package converter
+
+import (
+	"syscall"
+)
+
+var (
+	kernel32         = syscall.NewLazyDLL("kernel32.dll")
+	user32           = syscall.NewLazyDLL("user32.dll")
+	getConsoleWindow = kernel32.NewProc("GetConsoleWindow")
+	showWindow       = user32.NewProc("ShowWindow")
+)
+
+const SW_HIDE = 0
+
+func hideConsole() {
+	hwnd, _, _ := getConsoleWindow.Call()
+	if hwnd != 0 {
+		showWindow.Call(hwnd, SW_HIDE)
+	}
+}

html2pdf_test.go

@@ -1,6 +1,7 @@
 package html2pdf
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -46,6 +47,10 @@ func TestConvertFiles(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	c.SetProgressCallback(func(progress int) {
+		fmt.Println(progress)
+	})
+
 	if err := c.Convert(input...); err != nil {
 		t.Fatal(err)
 	}